kubeflow: make MLMD type names (and prefix) pluggable #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Mortari <[email protected]>
google-oss-prow
bot
requested review from
andreyvelich,
rareddy and
zijianjoy
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lampajr, rareddy, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/model-registry
Mar 4, 2024
* kubeflow: fix go module and odh. debranding (#15) * kubeflow: change go module name and references Signed-off-by: Andrea Lamparelli <[email protected]> * kubeflow: rename odh. into kfmr. Signed-off-by: tarilabs <[email protected]> * kubeflow: py: pyproject description Signed-off-by: tarilabs <[email protected]> * kubeflow: nit picks in text documents Signed-off-by: tarilabs <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: tarilabs <[email protected]> Co-authored-by: tarilabs <[email protected]> * Fix metadata OpenAPI spec (#17) * fix: OpenAPI metadata discriminator Signed-off-by: tarilabs <[email protected]> * wiring factories and default values missed in codegen Signed-off-by: tarilabs <[email protected]> * introduce openapi defaults Signed-off-by: tarilabs <[email protected]> * fix TestMetadataValue* Signed-off-by: Andrea Lamparelli <[email protected]> * fix: type assert generation Signed-off-by: Andrea Lamparelli <[email protected]> * upgrade openapi spec version to v1alpha2 Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: tarilabs <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Co-authored-by: tarilabs <[email protected]> * kubeflow: make MLMD type names (and prefix) pluggable (#19) Signed-off-by: Matteo Mortari <[email protected]> * build(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#20) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.61.1...v1.62.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * OAS: Fix discriminator field definition for Artifact (#22) * gitignore: ignore all coverage files Signed-off-by: Isabella Basso do Amaral <[email protected]> * OAS: fix discriminator field for Artifact Signed-off-by: Isabella Basso do Amaral <[email protected]> --------- Signed-off-by: Isabella Basso do Amaral <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: tarilabs <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Isabella Basso do Amaral <[email protected]> Co-authored-by: Andrea Lamparelli <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Isabella Basso <[email protected]>
tarilabs
added a commit
to tarilabs/model-registry
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #18
Description
GOALS:
kf.as a general default prefix, according to rough-consensus in GH issue and slack threadNON-GOALS:
How Has This Been Tested?
tested locally
Merge criteria: