Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeflow: disable codecov reporting GHA step #14

Merged

Conversation

tarilabs
Copy link
Member

this take immediate action to avoid failed builds due to this specific GHA step.

Description

Currently builds are failing on main as trying to report coverage data to Codecov which is not generally enabled in Kubeflow org.

How Has This Been Tested?

n/a

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • [n/a] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [n/a] The developer has manually tested the changes and verified that the changes work

@tarilabs tarilabs force-pushed the tarilabs-20240220-KFdisableCodecov branch from 9f6815b to 8b0d024 Compare February 20, 2024 08:27
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lampajr
Copy link
Member

lampajr commented Feb 20, 2024

/lgtm

Copy link

@lampajr: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@tarilabs: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lampajr, rareddy, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 314e7ed into kubeflow:main Feb 20, 2024
11 checks passed
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants