-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first draft of model registry kserve custom storage initializer #25
Add first draft of model registry kserve custom storage initializer #25
Conversation
Signed-off-by: Andrea Lamparelli <[email protected]>
thank you for sharing this draft @lampajr ! The way I would recommend to move forward is:
(if that volunteer is you reading this message, drop a comment below so we can coordinate!) |
I agree with you, I could work on these two points:
Such that there are enough information to try it (at least locally) then I think this PR could be considered as All other TODOs I think could be done in followup PRs. Wdyt? |
As discussed, marking this as
The following TODOs can be done in a separate/followup PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beyond minor/nit comment, I'd go ahead and merge this, as it provides already an helpful and pragmatic example of how other KF components/add-ons (in this case KServe) could integrate with Model Registry
46690b6
to
e304943
Compare
Signed-off-by: Andrea Lamparelli <[email protected]>
e304943
to
17eb714
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With reference to conversations in this PR, I'd go ahead and merge this, as it provides already an helpful and pragmatic example of how other KF components/add-ons (in this case KServe) could integrate with Model Registry
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lampajr, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#27) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add first draft of model registry kserve custom storage initializer (#25) * Add first draft of model registry custom storage initializer Signed-off-by: Andrea Lamparelli <[email protected]> * Add documentation and get started guide Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> * fix: ensure consistency ns(omitted) for istio manifests (#31) * fix: ensure consistency ns(omitted) for istio manifests Signed-off-by: Matteo Mortari <[email protected]> * add default ns to kustomization for consistency with manifests/kustomize/overlays/{db} kustomizations Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]> * fix CVE-2024-21626 (#34) see also: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMCONTAINERDCONTAINERD-6219724 Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
Fixes #24
Description
Provide a first draft of a possible Model Registry (KServe) Custom Storage Initializer based on https://github.com/lampajr/model-registry-storage-initializer PoC
TODOs:
Possible improvements (for further iterations)
kiota
to autogenerate the client, this will make the CSI less dependent on the internal model registry implementation (this will also make the CSI just tied to the openapi spec rather than MR version)How Has This Been Tested?
Merge criteria: