Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New(robot): Environment variable TEST_PORT for setting test port #28

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

rkubis
Copy link
Contributor

@rkubis rkubis commented Mar 5, 2024

Description

There is environment variable called TEST_MR_HOST for Robot Framework tests setting Model Registry host that can be used for testing Model Registry instance deployed anywhere, but there is not any environment variable for setting port of the instance for testing it.

This PR provides new environment variable called TEST_MR_PORT for setting test port of Robot Framework tests.

How Has This Been Tested?

  1. Deploy Model Registry instance anywhere with publicly reachable host and port.
  2. Run Robot Framework tests against it with setting TEST_MR_HOST and TEST_MR_PORT environment variable:
    TEST_MR_HOST=<model-registry-hostname> TEST_MR_PORT=<model-registry-port> robot test/robot/UserStory.robot

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rkubis rkubis force-pushed the add-test-port-env-var branch 2 times, most recently from f7c6d06 to eea16dc Compare March 5, 2024 16:03
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @rkubis for your PR ! 👏 this is very helpful to make it configurable

test/robot/MRkeywords.resource Outdated Show resolved Hide resolved
@rkubis rkubis force-pushed the add-test-port-env-var branch from 0e7139f to 30c2b40 Compare March 5, 2024 18:18
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy, rkubis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

tarilabs commented Mar 5, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 5, 2024
@google-oss-prow google-oss-prow bot merged commit ed52ec7 into kubeflow:main Mar 5, 2024
11 checks passed
@rkubis rkubis deleted the add-test-port-env-var branch March 6, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants