Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi: drop go from bin #292

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

isinyaaa
Copy link
Contributor

Follow-up to #288 . Aligns with CSI build.

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Isabella do Amaral <[email protected]>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @isinyaaa great catch

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isinyaaa
Copy link
Contributor Author

cc: @tarilabs

@google-oss-prow google-oss-prow bot merged commit 37be89d into kubeflow:main Aug 22, 2024
15 checks passed
@isinyaaa isinyaaa deleted the push-ululwsyqryqr branch August 22, 2024 14:05
dhirajsb added a commit to dhirajsb/model-registry-kfp that referenced this pull request Aug 30, 2024
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Signed-off-by: Isabella do Amaral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants