fix: ensure consistency ns(omitted) for istio manifests #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Mortari <[email protected]>
with manifests/kustomize/overlays/{db} kustomizations
Signed-off-by: Matteo Mortari <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhirajsb, rareddy, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/model-registry
Mar 8, 2024
* build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#27) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add first draft of model registry kserve custom storage initializer (#25) * Add first draft of model registry custom storage initializer Signed-off-by: Andrea Lamparelli <[email protected]> * Add documentation and get started guide Signed-off-by: Andrea Lamparelli <[email protected]> --------- Signed-off-by: Andrea Lamparelli <[email protected]> * fix: ensure consistency ns(omitted) for istio manifests (#31) * fix: ensure consistency ns(omitted) for istio manifests Signed-off-by: Matteo Mortari <[email protected]> * add default ns to kustomization for consistency with manifests/kustomize/overlays/{db} kustomizations Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]> * fix CVE-2024-21626 (#34) see also: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMCONTAINERDCONTAINERD-6219724 Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Andrea Lamparelli <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
tarilabs
pushed a commit
to tarilabs/model-registry
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for consistency, do not tie down to a given namespace
Description
How Has This Been Tested?
kubectl apply -n kubeflow -k manifests/kustomize/options/istioMerge criteria: