-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge model registry codebase from https://github.com/opendatahub-io/model-registry #6
Conversation
Moved pkg to internal since it's not meant to be exported as reusable pkg outside this project.
* add Shell script openshift-ci make some REST call to MR In the scope of testing of Model Registry in openshift-ci: - make a Shell script which invokes some REST calls to MR, - so to make sure the REST endpoint is responsive, - then create a K8s ISVC on the cluster, - and display the MR InferenceService entities. Later, in a subsequent issue/PR, once: opendatahub-io/odh-model-controller#135 is merged, the last bulletpoint can be automated and placed under test in the final part of this script so to make sure the K8s ISVC on the cluster reflected as a precise MR InferenceService entity. * omit OCP_CLUSTER_NAME to be valorized once on openshift-ci
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@v1.8.0...v1.9.0) --- updated-dependencies: - dependency-name: helm/kind-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@andreyvelich @zijianjoy all contributors are on the Red Hat corporate CLA and cla check is successful now. |
Thank you for confirming @dhirajsb , which action of the following should I perform?
|
Lets merge commit to preserve commit ids if we can. @tarilabs wdyt? |
I think @tarilabs has the rights to do it as well. Let's wait for his confirmation tomorrow. |
yes, #6 (comment)
yes, I confirm I have auth now to merge-commit; I'm just holding on "pushing the button" as I want to ensure we're fully coordinated internally (I can't act autonomously there), in order to minimise disruptions for our colleagues. Thank you for the PR again @dhirajsb this is super helpful |
Adding tonyxrmdavidson to OWNERS file
* Fix type_assert.patch * Improve openapi-server generation * Automate openapi server generation if something changed
…file. This is needed to allow the do-not-merge/invalid-owners-file label to be removed from openshift/release#48704 (kubeflow#312)
* doc: Document MR Logical Model * code review: add link from main README.md
* py: default metadata capture environment vars * linting
d05af7b
to
f4a4186
Compare
Signed-off-by: Andrew Block <[email protected]>
f4a4186
to
ba26588
Compare
@andreyvelich @zijianjoy It looks like the CLA check added a constraint for number of commits >250, which is failing. And there is a new DCO check that's failing since none of the original commits were signed. |
+1 to merge this manually since all the new commits are from Red Hat with a signed corporate CLA. |
+1 to merge this manually given:
👉 I will merge-commit to preserve commit hash (#6 (comment)) and code-attributions, all commits in this PR are coming from (human) Red Hatters or by bots from ODH/model-registry repo work operated by Red Hatters. I've also checked out the PR locally to ensure LICENSE, OWNERS and README.md are as intended. Thank you @dhirajsb for the great work and maintaining this PR to requests |
Description
Merged main branch from opendatahub-io org into kubeflow org model-registry repo.
How Has This Been Tested?
Verified docker image build locally on the merged branch.
Merge criteria: