-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bff): update bff service filtering to match model registry services by component: model-registry label #633
Conversation
As soon as you are able to review and (if it's all right) merge #630, I'll rebase this PR |
…ces by component: model-registry label Signed-off-by: Eder Ignatowicz <[email protected]>
b8be495
to
6caec82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing the mock mode and everything works. Need someone else to do the live cluster testing.
var httpPort int32 | ||
hasHTTPPort := false | ||
for _, port := range service.Spec.Ports { | ||
if port.Name == "http-api" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to assume the MR team won't change this port name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess so, otherwise it would need to change the contract of the service.
|
||
displayName := "" | ||
description := "" | ||
if service.Spec.ClusterIP == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is code from before, but is there a case where this would ever happen when deploying MR?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
This PR sits on top of #630 and update bff service filtering to match model registry services by component: model-registry label.
In this specific PR: (commit)
On clients/ui/bff/internal/integrations/k8s.go
As illustration, I've I remove the label filtering:
With filtering: