Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TLS auth on py client #64

Merged
merged 3 commits into from
May 9, 2024
Merged

Enable TLS auth on py client #64

merged 3 commits into from
May 9, 2024

Conversation

isinyaaa
Copy link
Contributor

@isinyaaa isinyaaa commented Apr 15, 2024 •
edited
Loading

Description

Now the python client will use TLS by default.

How Has This Been Tested?

Follow the MR operator README instructions for MySQL with TLS, then use the minimal example on the Python client's README.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@isinyaaa
Copy link
Contributor Author

@tarilabs @dhirajsb would appreciate it if you could test it too :) will update mTLS logic later to include the bearer token for SA via channel intercepts before marking as ready.

@isinyaaa isinyaaa force-pushed the tls-auth branch 2 times, most recently from 5c59b2d to 5fdf15b Compare April 18, 2024 22:30
@isinyaaa isinyaaa marked this pull request as ready for review April 18, 2024 22:32
@google-oss-prow google-oss-prow bot requested a review from Tomcli April 18, 2024 22:32
@isinyaaa isinyaaa force-pushed the tls-auth branch 3 times, most recently from 6383837 to 08e71fb Compare April 24, 2024 19:58
@isinyaaa isinyaaa force-pushed the tls-auth branch 2 times, most recently from edd0606 to 61394a8 Compare April 29, 2024 20:59
@isinyaaa isinyaaa requested a review from tarilabs April 29, 2024 21:05
@isinyaaa isinyaaa requested a review from tarilabs April 30, 2024 14:39
@isinyaaa isinyaaa requested a review from tarilabs May 2, 2024 14:17
@isinyaaa isinyaaa force-pushed the tls-auth branch 2 times, most recently from f9da0a9 to 75a93ec Compare May 2, 2024 17:00
@isinyaaa isinyaaa requested a review from rareddy May 2, 2024 18:33
rareddy
rareddy requested changes May 2, 2024
View reviewed changes
clients/python/src/model_registry/core.py Outdated Show resolved Hide resolved
clients/python/src/model_registry/core.py Outdated Show resolved Hide resolved
clients/python/src/model_registry/core.py Outdated Show resolved Hide resolved
@isinyaaa isinyaaa force-pushed the tls-auth branch 2 times, most recently from 4c66394 to 572c857 Compare May 3, 2024 01:05
dhirajsb
dhirajsb suggested changes May 3, 2024
View reviewed changes
clients/python/README.md Outdated Show resolved Hide resolved
clients/python/src/model_registry/_client.py
client_key: str | None = None,
server_cert: str | None = None,
custom_ca: str | None = None,
user_token: bytes | None = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a requirement right now, but we should open another issue to add support for client certificate as well for mutual authentication.

clients/python/src/model_registry/_client.py Outdated Show resolved Hide resolved
isinyaaa added 2 commits May 6, 2024 21:53
@isinyaaa
py: enable TLS auth by default
998aadc 
Signed-off-by: Isabella Basso do Amaral <[email protected]>
@isinyaaa
py: add user auth using SA
dae1626 
Signed-off-by: Isabella Basso do Amaral <[email protected]>
@isinyaaa isinyaaa requested a review from rareddy May 7, 2024 00:53
@isinyaaa isinyaaa force-pushed the tls-auth branch 2 times, most recently from 21bb87e to cd90dc6 Compare May 7, 2024 13:57
@isinyaaa isinyaaa requested review from dhirajsb and rareddy May 7, 2024 13:58
dhirajsb
dhirajsb suggested changes May 7, 2024
View reviewed changes
clients/python/src/model_registry/_client.py Outdated Show resolved Hide resolved
clients/python/src/model_registry/core.py Outdated Show resolved Hide resolved
dhirajsb
dhirajsb approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@dhirajsb dhirajsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow Google OSS Prow
Copy link

@dhirajsb: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rareddy
rareddy approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 9, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhirajsb, rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c4402c9 into kubeflow:main May 9, 2024
10 checks passed
@tarilabs tarilabs mentioned this pull request May 13, 2024
Merged
@isinyaaa isinyaaa deleted the tls-auth branch May 13, 2024 12:36
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request May 22, 2024
@tarilabs
Extend GHA to cover for Docker build (kubeflow#64)
5ef8c07
@isinyaaa isinyaaa mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@dhirajsb dhirajsb dhirajsb approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@Tomcli Tomcli Awaiting requested review from Tomcli

@tarilabs tarilabs Awaiting requested review from tarilabs

Assignees

@rareddy rareddy

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isinyaaa @dhirajsb @rareddy @tarilabs