Add support for env variables in the frontend #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
andreyvelich,
ederign and
Griffin-Sullivan
lucferbux
force-pushed
the
rhoaieng-10775
branch
2 times, most recently
from
0e2d003 to
40dce62
Compare
ederign
suggested changes
Dec 13, 2024
clients/ui/frontend/.env
Outdated
| IS_PROJECT_ROOT_DIR=false | ||
| PORT=${FRONTEND_PORT} | ||
|
|
||
| ########## Change the following three variables for ODH/OpenShift AI ########## |
There was a problem hiding this comment.
Suggested change
| ########## Change the following three variables for ODH/OpenShift AI ########## | |
| ########## Change the following variables to customize Model Registry Frontend on your Kubeflow distribution########## |
There was a problem hiding this comment.
Ah yes, this was just for copying a test and not going back, good catch thanks @ederign, it's now fixed!
Signed-off-by: lucferbux <[email protected]>
lucferbux
force-pushed
the
rhoaieng-10775
branch
from
40dce62 to
310e9a9
Compare
|
/lgtm |
ederign
approved these changes
Dec 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lucferbux
added a commit
to lucferbux/model-registry
that referenced
this pull request
Dec 19, 2024
Signed-off-by: lucferbux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for env variables in the frontend and add proper linting support.
How Has This Been Tested?
Merge criteria:
DCOcheck)If you have UI changes