-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bff): list user namespaces in dev mode #644
feat(bff): list user namespaces in dev mode #644
Conversation
Signed-off-by: Eder Ignatowicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works - code looks good - I think there's just one mistake in one of the test descriptions.
Co-authored-by: Alex Creasy <[email protected]> Signed-off-by: Eder Ignatowicz <[email protected]>
@alexcreasy all checks passed! |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR introduces a new endpoint (GET /v1/namespaces) in dev mode (standalone app) to populate the namespaces dropdown.
It's important to highlight that this new endpoint is only available in BFF dev mode (DEV_MODE=true)
Description
In this PR:
How Has This Been Tested?
Merge criteria:
DCO
check)