Py: Fix misleading errors on missing list results #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
tarilabs
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
I understand tests demonstrate get_artifacts/contexts methods now will return empty list instead of an error when registry is empty. An error TypeNotFoundException explicitly when the type definition is missing (ie: registry with no types initialized)
thank you @isinyaaa
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot bot
referenced
this pull request
in opendatahub-io/model-registry
Apr 17, 2024
* Py: Fix misleading errors on missing list results (#65) * py: fix type annotations to return concrete types Signed-off-by: Isabella Basso do Amaral <[email protected]> * py: fix missing type check on empty list results Signed-off-by: Isabella Basso do Amaral <[email protected]> --------- Signed-off-by: Isabella Basso do Amaral <[email protected]> * fix: OpenAPI ModelVersion shall contain registeredModelId property (#61) need to adapt property definition in OpenAPI to accomodate openapi-codegen result; according to contract (as also visible in swagger) the ModelVersion is to contain property: registeredModelId Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Isabella Basso do Amaral <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Isabella Basso <[email protected]> Co-authored-by: Matteo Mortari <[email protected]>
tarilabs
pushed a commit
to tarilabs/model-registry
that referenced
this pull request
Jun 19, 2024
[pull] main from kubeflow:main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses opendatahub-io/model-registry-bf4-kf#169.
How Has This Been Tested?
Merge criteria: