Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add owner to RegisteredModel logical model #70

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

tarilabs
Copy link
Member

In the logical model for RegisteredModel, add property owner of type string.

Note

Sanity checks to work better with local testing while using Podman (5.0.1) has been implemented as part of this PR.

Description

  • add to OpenAPI logical model
  • regenerate server, Go struct
  • implement goverter mappings
  • implement unit and integration test on Go side
  • align structure in Python client
  • implement test in Python client
  • implement e2e testing with RobotFramework
  • update documentation of logical model

How Has This Been Tested?

  • make test for Go
  • poetry run pytest for Python
Screenshot 2024-04-22 at 17 46 16
  • run RobotFramework manually raising MLMD in docker and running model-registry proxy
Screenshot 2024-04-22 at 17 20 48

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Copy link
Contributor

@isinyaaa isinyaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from the python side. thx a lot for the long overdue RM tests as well! much appreciated :)

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isinyaaa, rareddy, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ea66c4e into kubeflow:main Apr 29, 2024
10 checks passed
tarilabs pushed a commit to tarilabs/model-registry that referenced this pull request Jun 19, 2024
[pull] main from kubeflow:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants