-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add owner
to RegisteredModel
logical model
#70
add owner
to RegisteredModel
logical model
#70
Conversation
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from the python side. thx a lot for the long overdue RM tests as well! much appreciated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isinyaaa, rareddy, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[pull] main from kubeflow:main
In the logical model for
RegisteredModel
, add propertyowner
of type string.Note
Sanity checks to work better with local testing while using Podman (5.0.1) has been implemented as part of this PR.
Description
How Has This Been Tested?
Merge criteria: