Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubi docker file change #98

Closed

Conversation

tonyxrmdavidson
Copy link
Contributor

This PR updates the Dockerfile to point to ubi8:latests instead of ubi8:8.8

tarilabs and others added 30 commits February 19, 2024 21:52
…y011

py: update project version to v0.1.1
…idstream odh main

sync: upstream kubeflow main to midstream odh main
This commit will add Neha to model-registry OWNERS file
…ModelRegistryDeploy

This commit will deploy model-registry to the openshift-ci deployment
…pullBotConfigLabel

ci: configure Pull GH App bot to use tide label
* kubeflow: fix go module and odh. debranding (opendatahub-io#15)

* kubeflow: change go module name and references

Signed-off-by: Andrea Lamparelli <[email protected]>

* kubeflow: rename odh. into kfmr.

Signed-off-by: tarilabs <[email protected]>

* kubeflow: py: pyproject description

Signed-off-by: tarilabs <[email protected]>

* kubeflow: nit picks in text documents

Signed-off-by: tarilabs <[email protected]>

---------

Signed-off-by: Andrea Lamparelli <[email protected]>
Signed-off-by: tarilabs <[email protected]>
Co-authored-by: tarilabs <[email protected]>

* Fix metadata OpenAPI spec (opendatahub-io#17)

* fix: OpenAPI metadata discriminator

Signed-off-by: tarilabs <[email protected]>

* wiring factories and default values missed in codegen

Signed-off-by: tarilabs <[email protected]>

* introduce openapi defaults

Signed-off-by: tarilabs <[email protected]>

* fix TestMetadataValue*

Signed-off-by: Andrea Lamparelli <[email protected]>

* fix: type assert generation

Signed-off-by: Andrea Lamparelli <[email protected]>

* upgrade openapi spec version to v1alpha2

Signed-off-by: Andrea Lamparelli <[email protected]>

---------

Signed-off-by: tarilabs <[email protected]>
Signed-off-by: Andrea Lamparelli <[email protected]>
Co-authored-by: tarilabs <[email protected]>

* kubeflow: make MLMD type names (and prefix) pluggable (opendatahub-io#19)

Signed-off-by: Matteo Mortari <[email protected]>

* build(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.0 (opendatahub-io#20)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.61.1...v1.62.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* OAS: Fix discriminator field definition for Artifact (opendatahub-io#22)

* gitignore: ignore all coverage files

Signed-off-by: Isabella Basso do Amaral <[email protected]>

* OAS: fix discriminator field for Artifact

Signed-off-by: Isabella Basso do Amaral <[email protected]>

---------

Signed-off-by: Isabella Basso do Amaral <[email protected]>

---------

Signed-off-by: Andrea Lamparelli <[email protected]>
Signed-off-by: tarilabs <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Co-authored-by: Andrea Lamparelli <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isabella Basso <[email protected]>
…syncUpstream2

sync upstream KF into midstream ODH
* build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (opendatahub-io#27)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.4...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add first draft of model registry kserve custom storage initializer (opendatahub-io#25)

* Add first draft of model registry custom storage initializer

Signed-off-by: Andrea Lamparelli <[email protected]>

* Add documentation and get started guide

Signed-off-by: Andrea Lamparelli <[email protected]>

---------

Signed-off-by: Andrea Lamparelli <[email protected]>

* fix: ensure consistency ns(omitted) for istio manifests (opendatahub-io#31)

* fix: ensure consistency ns(omitted) for istio manifests

Signed-off-by: Matteo Mortari <[email protected]>

* add default ns to kustomization for consistency

with manifests/kustomize/overlays/{db} kustomizations

Signed-off-by: Matteo Mortari <[email protected]>

---------

Signed-off-by: Matteo Mortari <[email protected]>

* fix CVE-2024-21626 (opendatahub-io#34)

see also: https://security.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMCONTAINERDCONTAINERD-6219724

Signed-off-by: Matteo Mortari <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Andrea Lamparelli <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <[email protected]>
Co-authored-by: Matteo Mortari <[email protected]>
…ndatahub-io#26)

* This commit will add a yaml deployment file to deploy the latest ODH operator used in the nightly runs

* This commit will change the target file for ODH deployment to model-registry-data-science-cluster-nightly.yaml

* This commit will add a file to create a catalogue source for the nighlty ODH image.

* This commit will change the operator deployment to a subscription model.

* This commit adds a catalogue source command to the script and comments out the DSC_INITIALIZATION_MANAIFEST command.

* This commit will appropriately name files and complete the the deployment and the deployment tests

* This commit will update the image used in the catalogue source and delete wrongly named files

* This commit will remove files no longer needed.

* This commit will delete the file delete_resources.sh

* This commit will add an empty line to the end of the file

* This commit add a pod status check for the model-registry-operator-controller-manager pods

* This commit removes an unneeded echo command

* This commit changes the pod status check oc command to use selectors instead of grep

* This commit changes the label used for the model-registry-operator to an appropriate label

* This commit un-comments function calls

* This commit removes unnessesary echo
)

* This commit will update the iib for odh-nightly build
and fix the paths as the script will be run from the root of the repo instead of directly from the host directory

* This commit removes color text from echo statements
rkubis and others added 14 commits April 23, 2024 14:10
This commit will remove Trusty-ai from the deployment
…io#52)

* Update(openshift-ci/scripts): Increase API version of Model Registry

* Update(test/scripts): Increase API version of Model Registry
* This commit will change the success label for a 404 return to a yellow warning.

* removing double echo
Signed-off-by: Matteo Mortari <[email protected]>
…Script

This commit adds a script that will push data to model-registry-db fo…
…sync

periodic sync upstream KF to midstream ODH
…sync

periodic sync upstream KF to midstream ODH
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubeflow org. You can then trigger verification by writing /verify-owners in a comment.

  • tonyxrmdavidson
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS
  • dhirajsb
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS
  • isinyaaa
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS
  • nehachopra27
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS
  • rkubis
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@efe499d). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage        ?   78.65%           
=======================================
  Files           ?       14           
  Lines           ?      745           
  Branches        ?      101           
=======================================
  Hits            ?      586           
  Misses          ?      127           
  Partials        ?       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonyxrmdavidson tonyxrmdavidson deleted the ubiDockerFileChange branch May 16, 2024 15:40
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request May 22, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Jul 25, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Jul 25, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Jul 25, 2024
- adapt GHA "env.IMG_ORG" variable
- populate csi/Makefile IMG_REGISTRY variable
- adapt GHA csi-* steps for IMG variables,
to be analogous to
.github/workflows/build-and-push-image.yml
value of IMG variables (prefix "quay.io/")

Signed-off-by: Matteo Mortari <[email protected]>
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Jul 25, 2024
- adapt GHA "env.IMG_ORG" variable
- populate csi/Makefile IMG_REGISTRY variable
- reflect csi/Makefile default for IMG_ORG
- adapt GHA csi-* steps for IMG variables,
to be analogous to
.github/workflows/build-and-push-image.yml
value of IMG variables (prefix "quay.io/")

Signed-off-by: Matteo Mortari <[email protected]>
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Jul 25, 2024
- adapt GHA "env.IMG_ORG" variable
- populate csi/Makefile IMG_REGISTRY variable
- reflect csi/Makefile default for IMG_ORG
- adapt GHA csi-* steps for IMG variables,
to be analogous to
.github/workflows/build-and-push-image.yml
value of IMG variables (prefix "quay.io/")

Co-authored-by: Andrea Lamparelli <[email protected]>

Signed-off-by: Matteo Mortari <[email protected]>
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Jul 25, 2024
- adapt GHA "env.IMG_ORG" variable
- populate csi/Makefile IMG_REGISTRY variable
- reflect csi/Makefile default for IMG_ORG
- adapt GHA csi-* steps for IMG variables,
to be analogous to
.github/workflows/build-and-push-image.yml
value of IMG variables (prefix "quay.io/")

Signed-off-by: Matteo Mortari <[email protected]>

Co-authored-by: Andrea Lamparelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants