Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add action for semantic PR titles and apply labels #14

Open
wants to merge 3 commits into
base: notebooks-v2
Choose a base branch
from

Conversation

Adembc
Copy link

@Adembc Adembc commented Jun 3, 2024

No description provided.

Signed-off-by: Adem Baccara <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

jiridanek commented Jun 20, 2024

I think I'd prefer a conventional commit bot over this. There's 21.5k lines of Javascript in this PR, and only about 100 lines of it is handwritten, the rest are dependencies! Anyways, it does not look wrong to me, so

/lgtm

Copy link

@jiridanek: changing LGTM is restricted to collaborators

In response to this:

I think I'd prefer a conventional commit bot over this. There's 21.5k lines of Javascript in this PR! Anyways, it does not look wrong to me, so

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Adembc
Copy link
Author

Adembc commented Jun 20, 2024

Thank you @jiridanek , for reviewing.
We discussed this issue in our last meeting and decided to create a new branch for the conventional-release-labels GHA code. @thesuperzapper will take care of this, and I will update this PR to reference it using kubeflow/notebooks/PATH@BRANCH.

@thesuperzapper thesuperzapper added the area/ci area - related to ci label Jul 18, 2024
@thesuperzapper thesuperzapper added this to the Repo Setup milestone Jul 18, 2024
@thesuperzapper thesuperzapper self-assigned this Jul 18, 2024
@thesuperzapper thesuperzapper removed this from the Repo Setup milestone Jul 18, 2024
@thesuperzapper thesuperzapper added the project/repo-setup project - repo setup and health label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area - related to ci project/repo-setup project - repo setup and health size/XXL
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants