Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ws): implement culling controller #63

Open
wants to merge 12 commits into
base: notebooks-v2
Choose a base branch
from
Open

feat(ws): implement culling controller #63

wants to merge 12 commits into from

Conversation

Adembc
Copy link

@Adembc Adembc commented Oct 7, 2024 •
edited by thesuperzapper
Loading

Closes #38

WIP

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Adembc
feat(ws): implement culling controller
15db52a 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
update workspace kind crd
93e21a6 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
wip
3fdead0 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
fetch podName
d38011f 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
implment bash probe
56ebc49 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
implment bash probe
4fbf62e 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
implment bash probe
3fae9e2 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
implment bash probe
53fd020 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
implment bash probe
fc8aeb5 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
fix tests
ab8424d 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
get ws port
b26157f 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc
update rbac
74ab3ff 
Signed-off-by: Adem Baccara <[email protected]>
@Adembc Adembc marked this pull request as ready for review November 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees
No one assigned
Labels
size/XL
Projects
Kubeflow Notebooks
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Adembc