-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automates backend deployment #74
Conversation
Signed-off-by: KapilSareen <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kimwnasptd, any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will require some work. On controller, we use kustomize and we need to follow the same procedure that we are using there.
In addition to that, we need clarification on points, i.e., roles, services, and service accounts. I've added it as a topic to define this topology on our next community call. 2024-11-21 8:00 AM PT (check kubeflow calendar for the link).
@KapilSareen my recommendation right now, until we have such definitions, is if you find any issues with our docker image build, maybe repurpose this PR to fix them?
Then, we can address the automated deployment after the definitions on the community call.
That sounds great! I've repurposed the PR to address that. However, I have other commitments around the time of the community call. Please do share the insights, and I'll make sure to work on them. |
Hey @ederign can you brief what was decided about this in the recent community call? |
I dont think this PR is addressing any current issues and would actually break the relative import of the controller code, I am going to close it. /close |
@thesuperzapper: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description:
This PR automates the deployment process for the application's backend component, resolving the issue mentioned in #45. It introduces two new Makefile commands,
deploy
andundeploy
, which streamline the process of deploying and undeploying the application on a Kubernetes cluster.Additionally, some fixes have been applied to the
Dockerfile
andgo.mod
to address issues preventing the successful execution of thedocker-build
command.