Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): multi-user mode manifests for subject access review integration. Fixes #3513 #5314

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Mar 17, 2021

Fixes #3513

Description of your changes:
Changes:

  • rename kubeflow-pipeline-edit cluster role to kubeflow-pipelines-edit (Kubeflow Pipelines is the official brand)
  • move subjectaccessreview related manifests to multi-user install folder, so it's builtin for KFP multi-user mode
  • sync ml-pipeline cluster role with permissions needed in ml-pipeline role

Checklist:

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 17, 2021

/assign @elikatsis @yanniszark @zijianjoy

@Bobgy Bobgy changed the title refactor(deployment): multi-user mode manifests for subject access review integration. Fixes #3513 feat(deployment): multi-user mode manifests for subject access review integration. Fixes #3513 Mar 17, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 17, 2021

@zijianjoy this is the last blocker for KFP multi-user mode release.
I'll release a RC after this, which you can try to integrate to Kubeflow on GCP.

@elikatsis
Copy link
Member

LGTM
[I'm not writing it as a command so that others get to see it as well]

@zijianjoy
Copy link
Collaborator

/lgtm
/approve

Thank you Yuan!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 4e2c455 into kubeflow:master Mar 18, 2021
@Bobgy Bobgy deleted the sar-manifest branch March 19, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-User Authorization: Add support for K8s RBAC via SubjectAccessReview
5 participants