Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc to reflect new version for Azure #3709

Closed
wants to merge 1 commit into from

Conversation

mosabami
Copy link
Contributor

@mosabami mosabami commented Apr 8, 2024

I didnt know how the azure/latest-version tag works so i just hardcoded the latest versions. if someone can explain to me how its able to identify latest version, that would be great.

Copy link

Hi @mosabami. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mosabami
Once this PR has been reviewed and has the lgtm label, please assign 8bitmp3 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from alfsuse and knkski April 8, 2024 23:27
@rimolive
Copy link
Member

rimolive commented Apr 9, 2024

@mosabami The correct way to change AKS distribution to the version you want is changing https://github.com/kubeflow/website/blob/master/layouts/shortcodes/azure/latest-version.html file.

By the way, we are about to reach feature freeze date for Kubeflow 1.9 and we contacted all distribution owners to confirm if they will participate in the distribution testing phase. Can you help us identify the AKS distribution owners and ask them if they will participate in the distribution testing? kubeflow/manifests#2611

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@varodrig
Copy link
Contributor

varodrig commented Dec 6, 2024

@rimolive is this still valid?

@varodrig
Copy link
Contributor

@mosabami The correct way to change AKS distribution to the version you want is changing https://github.com/kubeflow/website/blob/master/layouts/shortcodes/azure/latest-version.html file.

By the way, we are about to reach feature freeze date for Kubeflow 1.9 and we contacted all distribution owners to confirm if they will participate in the distribution testing phase. Can you help us identify the AKS distribution owners and ask them if they will participate in the distribution testing? kubeflow/manifests#2611

@mosabami requesting changes as per @rimolive comments.

@varodrig
Copy link
Contributor

varodrig commented Dec 17, 2024

/close

as suggested by @rimolive cc @mosabami please create a new PR updating the file requested by @rimolive . thank you

Copy link

@varodrig: Closed this PR.

In response to this:

/close

as suggested by @rimolive cc @mosabami

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants