-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make vpc_nat_gateway redo eip fip snat dnat iptables rules after k8s cluster reboot #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobz965
requested changes
Sep 28, 2023
oilbeater
requested changes
Oct 31, 2023
@wenwenxiong hi, are you still working on this pr? |
if not, I will go on finish this pr. |
i am not to do with this pr now |
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
bobz965
approved these changes
Nov 30, 2023
oilbeater
approved these changes
Dec 5, 2023
pandaoknight
pushed a commit
to pandaoknight/kube-ovn
that referenced
this pull request
Mar 19, 2024
…cluster reboot (kubeovn#3267) * make vpc_nat_gateway judge redo snat dnat iptables rules after k8s cluster reboot Signed-off-by: bobz965 <[email protected]> --------- Signed-off-by: bobz965 <[email protected]> Co-authored-by: xiongww <[email protected]> Co-authored-by: bobz965 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(#3241)
WHAT
🤖 Generated by Copilot at b54535b
This pull request improves the reliability and consistency of the NAT gateway controller and the FIP feature. It adds logic to handle pod restarts and redo iptables rules for EIP, FIP, DNAT, and SNAT objects. It also changes the default value of the
pod-default-fip-type
flag to "iptables" and adds a function to initialize the VPC NAT gateways.🤖 Generated by Copilot at b54535b
HOW
🤖 Generated by Copilot at b54535b
pod-default-fip-type
flag to "iptables" to match the documentation and code logic (link)initResourceOnce
function (link)initVpcNatGw
function to list and enqueue the VPC NAT gateways for initialization and check their annotations (link)time
package to parse and compare timestamps for the EIP, FIP, DNAT, and SNAT configurations (link)handleAddIptablesEip
,handleAddIptablesFip
,handleAddIptablesDnatRule
, andhandleAddIptablesSnatRule
functions, respectively, and reconfigure them if needed (link, link, link, link, link, link, link)