Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: use dedicated port for health probe #3285

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Oct 8, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

E1008 05:38:22.824728       1 http.go:72] admission "msg"="unable to process a request with unknown content type" "error"="contentType=, expected application/json"

WHAT

🤖 Generated by Copilot at bdc3fe0

This pull request adds health and readiness probes to the webhook service of kube-ovn using the healthz package and environment variables. It also updates the cert-manager dependency and makes the webhook image configurable in the Makefile. The yamls/webhook.yaml file is modified accordingly to reflect these changes.

🤖 Generated by Copilot at bdc3fe0

Webhook service grows
healthz probes and cert-manager
Autumn of updates

HOW

🤖 Generated by Copilot at bdc3fe0

@zhangzujian zhangzujian marked this pull request as ready for review October 8, 2023 06:00
@zhangzujian zhangzujian requested review from oilbeater and removed request for oilbeater October 8, 2023 06:00
@zhangzujian zhangzujian marked this pull request as draft October 8, 2023 07:24
@zhangzujian zhangzujian marked this pull request as ready for review October 8, 2023 07:34
@zhangzujian zhangzujian requested a review from oilbeater October 8, 2023 07:34
@zhangzujian zhangzujian merged commit 4af1960 into kubeovn:master Oct 9, 2023
58 checks passed
@zhangzujian zhangzujian deleted the fix-webhook-log branch October 9, 2023 01:31
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Oct 9, 2023
zhangzujian added a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants