support custom vpc dns its deployment replicas #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bobz965 <[email protected]>
bobz965
force-pushed
the
vpc-dns-cust-replica
branch
from
344473f to
2953fc3
Compare
Signed-off-by: bobz965 <[email protected]>
oilbeater
approved these changes
Oct 8, 2023
bobz965
added a commit
that referenced
this pull request
Oct 9, 2023
* support custom vpc dns its deployment replicas * the provider is not necessary --------- Signed-off-by: bobz965 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
support run only one vpc-dns pod in all-in-one env
NAD maps to ovn-default, but the ovn-default's spec provider is no need to change as ovn-nad.default.ovn
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 344473f
Add
replicasfield toVpcDNSSpecto support VpcDns scaling and high availability. Update CRD schemas, Go types, and controller logic to handle the new field.🤖 Generated by Copilot at 344473f
HOW
🤖 Generated by Copilot at 344473f
replicasin theVpcDNSSpecschema (link, link)VpcDNSSpectype in the Go code to match the CRD schema and add thejson:"replicas"tag (link)createOrUpdateVpcDNSDepfunction in the VpcDns controller to set theReplicasfield of theDeploymentSpecaccording to the user's specification (link)