ovn-ic-ecmp refactor #3632
Merged
ovn-ic-ecmp refactor #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
requested changes
Jan 22, 2024
pkg/ovn_ic_controller/config.go
Outdated
Comment on lines
31
to
36
| NodeSwitchCIDR string | ||
|
|
||
| ClusterTCPLoadBalancer string | ||
| ClusterUDPLoadBalancer string | ||
| ClusterTCPSessionLoadBalancer string | ||
| ClusterUDPSessionLoadBalancer string |
There was a problem hiding this comment.
These fields are not used
oilbeater
approved these changes
Jan 22, 2024
oilbeater
requested changes
Jan 25, 2024
| @@ -115,6 +123,15 @@ func (c LegacyClient) DestroyRoutes(uuids []string) { | |||
| } | |||
| } | |||
|
|
|||
| func (c LegacyClient) DestroyPortBindings(uuids []string) { | |||
| for _, uuid := range uuids { | |||
| if err := c.DestroyTableWithUUID(uuid, "Port_Binding"); err != nil { | |||
There was a problem hiding this comment.
should return err when failed
| func (c *Controller) getTSName(index int) string { | ||
| if index == 0 { | ||
| return util.InterconnectionSwitch | ||
| func moveElements(arr []string, order int) []string { |
There was a problem hiding this comment.
Suggested change
| func moveElements(arr []string, order int) []string { | |
| func removeElement(arr []string, order int) []string { |
There was a problem hiding this comment.
it renamed it to generateNewOrdergwNodes
Signed-off-by: changluyi <[email protected]> Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
2. add ovn-ic-controller.log to hostpath Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
changluyi
force-pushed
the
ovn-ic-ecmp-enhance-master
branch
from
e469ddb to
53aed0c
Compare
2. refactor function name Signed-off-by: Changlu Yi <[email protected]>
oilbeater
approved these changes
Jan 26, 2024
Signed-off-by: Changlu Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough