Make dhcpOptions can accept multiple addresses #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this implementation, we set dns_server={8.8.8.8;42.42.42.42} in subnet and transfer to {8.8.8.8, 42.42.42.42} in ovn-ndb. |
bobz965
approved these changes
May 11, 2024
|
在 ovn nb 的文档中，dns 相关的配置中是{ip1,ip2},指定多个 ip 也是逗号分隔的。 这里 kube-ovn 要求用户使用分号“；” 分隔多个 ip 是为了便于之前的代码仍然可以解析。 @zhangzujian please help review， thanks！ |
zhangzujian
reviewed
May 12, 2024
zhangzujian
reviewed
May 13, 2024
Longchuanzheng
force-pushed
the
dhcpallowiplist
branch
from
92ae68d to
92f19fa
Compare
zhangzujian
approved these changes
May 13, 2024
Signed-off-by: zhuanlan <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: zhuanlan <[email protected]>
zcq98
pushed a commit
to zcq98/kube-ovn
that referenced
this pull request
May 16, 2024
Signed-off-by: zhuanlan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4002