Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback residual link and port #4012

Merged
merged 1 commit into from
May 16, 2024

Conversation

fanriming
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Rollback residual link and port when an error occurs.

@zhangzujian
Copy link
Member

err is shadowed in the block patching pod annotations.

And the returned value of the following statement should be assigned to err:

return configureContainerNic(containerNicName, ifName, ip, gateway, isDefaultRoute, detectIPConflict, routes, macAddr, podNS, mtu, nicType, gwCheckMode, u2oInterconnectionIP)

@fanriming fanriming force-pushed the rollback-residua-port branch from cd4d2d9 to 55fe567 Compare May 14, 2024 09:35
@fanriming
Copy link
Member Author

err is shadowed in the block patching pod annotations.

And the returned value of the following statement should be assigned to err:

return configureContainerNic(containerNicName, ifName, ip, gateway, isDefaultRoute, detectIPConflict, routes, macAddr, podNS, mtu, nicType, gwCheckMode, u2oInterconnectionIP)

done

@fanriming fanriming force-pushed the rollback-residua-port branch from 55fe567 to fdf595c Compare May 15, 2024 02:23
@zhangzujian zhangzujian merged commit fa66889 into kubeovn:master May 16, 2024
62 checks passed
zcq98 pushed a commit to zcq98/kube-ovn that referenced this pull request May 16, 2024
bobz965 pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants