fix: gateway should not be network address and broadcast address #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobz965
approved these changes
May 17, 2024
|
@zhangzujian please help review, thanks! |
|
|
但是不仅是subnet的gateway校验有问题，其它能指定IP的地方都存在可以将ip指定为网络地址/广播地址的问题 |
那我们就把这些地方找出来逐一修复掉。如果工作量比较大，这个 PR 可以先只修复 gateway 地址。 |
zhangzujian
reviewed
May 21, 2024
zcq98
force-pushed
the
gateway-check
branch
2 times, most recently
from
d29f89f to
4c29b3f
Compare
zhangzujian
reviewed
May 21, 2024
zhangzujian
reviewed
May 22, 2024
zhangzujian
approved these changes
May 22, 2024
added 3 commits
May 23, 2024 10:29
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
May 23, 2024
* fix: gateway should not be network address and broadcast address --------- Signed-off-by: zcq98 <[email protected]> Signed-off-by: bobz965 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4041