Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovs: get controllerrevision with option --ignore-not-found #4058

Merged
merged 3 commits into from
May 24, 2024
Merged

ovs: get controllerrevision with option --ignore-not-found #4058

merged 3 commits into from
May 24, 2024

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented May 21, 2024 •
edited
Loading

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Error from server (NotFound): controllerrevisions.apps "ovs-ovn-874f78948" not found

@zhangzujian zhangzujian added bug Something isn't working need backport labels May 21, 2024
@zhangzujian zhangzujian marked this pull request as ready for review May 21, 2024 04:42
@zhangzujian zhangzujian requested a review from oilbeater May 21, 2024 04:42
@zhangzujian zhangzujian removed the request for review from oilbeater May 21, 2024 06:44
@zhangzujian zhangzujian marked this pull request as draft May 21, 2024 06:44
@zhangzujian zhangzujian force-pushed the fix-cleanup branch 5 times, most recently from 30477ee to c47c27d Compare May 21, 2024 08:02
@zhangzujian zhangzujian changed the title ovs: get controllerrevision with option --ignore-not-found fix ovs-ovn not terminated on cleanup/uninstallation May 21, 2024
@zhangzujian zhangzujian marked this pull request as ready for review May 21, 2024 08:43
@zhangzujian zhangzujian requested a review from oilbeater May 21, 2024 08:43
@zhangzujian zhangzujian removed the request for review from oilbeater May 21, 2024 12:13
@zhangzujian zhangzujian marked this pull request as draft May 21, 2024 12:13
@zhangzujian zhangzujian force-pushed the fix-cleanup branch 3 times, most recently from 0bd548b to fec152c Compare May 22, 2024 13:50
@zhangzujian zhangzujian changed the title fix ovs-ovn not terminated on cleanup/uninstallation ovs: get controllerrevision with option --ignore-not-found May 22, 2024
@zhangzujian zhangzujian removed the bug Something isn't working label May 22, 2024
@zhangzujian zhangzujian marked this pull request as ready for review May 22, 2024 13:51
@zhangzujian zhangzujian requested review from oilbeater and removed request for oilbeater May 22, 2024 13:51
@zhangzujian zhangzujian marked this pull request as draft May 22, 2024 14:28
@zhangzujian zhangzujian marked this pull request as ready for review May 24, 2024 02:02
@zhangzujian zhangzujian requested a review from oilbeater May 24, 2024 02:02
@zhangzujian zhangzujian merged commit aebe363 into kubeovn:master May 24, 2024
62 checks passed
@zhangzujian zhangzujian deleted the fix-cleanup branch May 24, 2024 06:06
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request May 24, 2024
@zhangzujian
ovs: get controllerrevision with option --ignore-not-found (kubeovn#4058
2653759 
)

Signed-off-by: zhangzujian <[email protected]>
bobz965 pushed a commit that referenced this pull request May 24, 2024
@zhangzujian
ovs: get controllerrevision with option --ignore-not-found (#4058)
d30d7e8 
Signed-off-by: zhangzujian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangzujian @oilbeater