Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up legacy iptables rules only when iptables/ip6_tables is loaded #4855

Merged
merged 1 commit into from
Dec 24, 2024
Merged

clean up legacy iptables rules only when iptables/ip6_tables is loaded #4855

merged 1 commit into from
Dec 24, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. go Pull requests that update Go code labels Dec 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12405774915

Details

  • 0 of 31 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 22.116%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/controller_linux.go 0 31 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/daemon/controller_linux.go 2 0.0%
Totals Coverage Status
Change from base Build 12403800192: -0.01%
Covered Lines: 10164
Relevant Lines: 45958
💛 - Coveralls

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
@oilbeater oilbeater merged commit 8ecbae8 into kubeovn:master Dec 24, 2024
66 of 68 checks passed
oilbeater pushed a commit that referenced this pull request Dec 24, 2024
@zhangzujian @oilbeater
clean up legacy iptables rules only when iptables/ip6_tables is loaded (
2cc515e 
#4855)

Signed-off-by: zhangzujian <[email protected]>
@zhangzujian zhangzujian deleted the fix-legacy branch December 24, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer need backport size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangzujian @coveralls @oilbeater