fix: kube-ovn-controller cannot be ready when ENABLE_METRICS is false

[zcq98]

Pull Request

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

Examples of user facing changes:

• Bug fixes

Which issue(s) this PR fixes

Fixes #4862

[coveralls]

Pull Request Test Coverage Report for Build 12464002853

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage remained the same at 22.126%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/ovs/ovn-nb-port_group.go	2	82.53%

Totals
Change from base Build 12434320848:	0.0%
Covered Lines:	10164
Relevant Lines:	45937

---

💛 - Coveralls

[zcq98]

@zhangzujian could you help review this?

[oilbeater]

This will also enable the metrics endpoint, which is not the intended purpose of this configuration.

[bobz965]

This will also enable the metrics endpoint, which is not the intended purpose of this configuration.

那就要把这个配置项用上，而不是无关乎这个配置项。也还要解决关闭的情况下，健康检查的问题。
在yaml 模版中要处理？难道不开启 enable metric 就不进行健康检查么？ 这样好像也不合适

[oilbeater]

健康检查应该只检查端口是否开启就可以，不需要访问 metrics 内容

[bobz965]

健康检查应该只检查端口是否开启就可以，不需要访问 metrics 内容

我们这边的理解是 enalbe metric 为 true， 服务才会监听在 10660 ，否则现有逻辑直接 return ，没有监听