Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize Openstack preset values #6807

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Customize Openstack preset values #6807

merged 4 commits into from
Sep 16, 2024

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Sep 3, 2024 •
edited by ahmedwaleedmalik
Loading

What this PR does / why we need it:
This PR adds functionality in Openstack provider to customize non-credential values of preset during cluster creation.
A new checkbox called "Is Customizable" is also added in preset dialog which enables this customization functionality.

Which issue(s) this PR fixes:

Ref #6756

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add functionality for Openstack provider to customize non-credential values of preset during cluster creation.

Documentation:

https://github.com/kubermatic/docs/pull/1764

@kubermatic-bot kubermatic-bot added do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api Denotes a PR or issue as being assigned to SIG API. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
@ahmadhamzh ahmadhamzh changed the title update editable values api WIP update editable values api Sep 3, 2024
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
@Waseem826 Waseem826 changed the title WIP update editable values api [WIP] Customizable provider preset Sep 9, 2024
@ahmadhamzh ahmadhamzh changed the title [WIP] Customizable provider preset [WIP] Customize openstack preset Sep 9, 2024
@ahmadhamzh ahmadhamzh force-pushed the make-preset-customizable branch 4 times, most recently from a39cc42 to e8476fa Compare September 11, 2024 09:25
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2024
@ahmadhamzh ahmadhamzh force-pushed the make-preset-customizable branch 3 times, most recently from f97de28 to 8a67d1e Compare September 11, 2024 22:54
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 11, 2024
@ahmadhamzh
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2024
@ahmadhamzh
Copy link
Contributor Author

/retest

@ahmadhamzh
Copy link
Contributor Author

/retest

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/tbd Denotes a PR that needs documentation (change) that will be done later. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Sep 13, 2024
@Waseem826 Waseem826 changed the title [WIP] Customize openstack preset Customize Openstack preset values Sep 13, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@Waseem826
Copy link
Contributor

/unhold
/kind feature

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 13, 2024
@Waseem826 Waseem826 added this to the KKP 2.26 milestone Sep 13, 2024
@Waseem826
Copy link
Contributor

/retest

@ahmedwaleedmalik
Copy link
Member

This will not close #6756, this PR is the first step towards achieving this functionality in KKP and adds support for OpenStack, only.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7e9b9221c1e73309f07b3798879c697ea92136e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@kubermatic-bot kubermatic-bot merged commit e5f0256 into kubermatic:main Sep 16, 2024
13 of 14 checks passed
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Sep 16, 2024
Open
@Waseem826 Waseem826 mentioned this pull request Sep 19, 2024
Closed
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.26
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmadhamzh @Waseem826 @ahmedwaleedmalik @kubermatic-bot