feat: add helm deploy for edge

[vie-serendipity]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Deploy multi daemonsets using values-nodepools according to affinity. And csi config will overwrite the original config.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @vie-serendipity. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[huww98]

Can we just use the key in .Values.nodepools as the name? e.g.

{{ if eq $key "default" }}
name: csi-plugin
{{ else }}
name: csi-pluign-{{ $key }}
{{ end }}

We can avoid possible duplicated name in this way.

[vie-serendipity]

I personally think it's more readable to explicitly clarify names of each node pool. It makes no real difference compared to using $key as we do now.

[huww98]

OK. But this way we lost a level of abstraction. e.g. kubectl get pods -l nodepool=edge seems more reasonable than -l nodepool=csi-plugin-edge

How about

{{ if eq $key "default" }}
name: csi-plugin
{{ else }}
name: csi-pluign-{{ .name }}
{{ end }}

the name of default pool can still be used in label.

[huww98]

values-edge.yaml is the config we use in our ACK Edge cluster. I think we'd better keep its name.

[huww98]

Please rebase and apply these change

diff --git a/deploy/chart/templates/plugin.yaml b/deploy/chart/templates/plugin.yaml
index 2ee66ad7..3092b4dd 100644
--- a/deploy/chart/templates/plugin.yaml
+++ b/deploy/chart/templates/plugin.yaml
@@ -148,7 +148,7 @@ spec:
               mountPath: /var/lib/kubelet/
               mountPropagation: "Bidirectional"
 {{- range $key := tuple "disk" "nas" "oss" }}
-  {{- with index $.Values.csi $key -}}
+  {{- with index $nodePool.csi $key -}}
     {{- if .enabled }}
             - name: {{ $key }}-plugin-dir
               mountPath: /csi/{{ $key }}plugin.csi.alibabacloud.com
@@ -301,7 +301,7 @@ spec:
           hostPath:
             path: /var/lib/kubelet
             type: Directory
-{{- range $key, $val := .Values.csi }}
+{{- range $key, $val := $nodePool.csi }}
 {{- if $val.enabled }}
         - name: {{ $key }}-plugin-dir
           hostPath:

[mowangdk]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk, vie-serendipity

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mowangdk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment