Skip to content

Commit

Permalink
Fix kubelet-csr-approver deployment failes if kube_network_plugin=cni…
Browse files Browse the repository at this point in the history
…(generic) (#11704)

* Make Helm's 'atomic' parameter configurable from role variables

* Configure Helm with 'atomic' and 'wait' set to false for generic CNI to prevent kubelet-csr-approver installation failures
  • Loading branch information
M-JavadHeydarpour authored Nov 16, 2024
1 parent c4b53ff commit e8bdd47
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions roles/helm-apps/meta/argument_specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ argument_specs:
default: true
wait_timeout:
type: str
atomic:
type: bool
default: true

repositories:
type: list
Expand Down Expand Up @@ -91,3 +94,6 @@ argument_specs:
wait_timeout:
type: str
default: "5m"
atomic:
type: bool
default: true
3 changes: 2 additions & 1 deletion roles/kubernetes-apps/kubelet-csr-approver/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ dependencies:
namespace: "{{ kubelet_csr_approver_namespace }}"
chart_ref: "{{ kubelet_csr_approver_chart_ref }}"
chart_version: "{{ kubelet_csr_approver_chart_version }}"
wait: true
wait: "{{ kube_network_plugin != 'cni' }}"
atomic: "{{ kube_network_plugin != 'cni' }}"
values: "{{ kubelet_csr_approver_values }}"
repositories:
- name: "{{ kubelet_csr_approver_repository_name }}"
Expand Down

0 comments on commit e8bdd47

Please sign in to comment.