Switch to 'yaml.v3' #100
Switch to 'yaml.v3' #100
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
sig/api-machinery
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
inteon
force-pushed
the
remove_unused_code
branch
from
600f900 to
9c0c75c
Compare
| @@ -119,6 +123,7 @@ func (dec *Decoder) KnownFields(enable bool) { | |||
| func (dec *Decoder) Decode(v interface{}) (err error) { | |||
| d := newDecoder() | |||
| d.knownFields = dec.knownFields | |||
| d.uniqueKeys = !dec.noUniqueKeys | |||
There was a problem hiding this comment.
This exising uniqueKeys option is exposed for the non-strict unmarshaller.
There was a problem hiding this comment.
Is this new? I don't remember this option in the v2 decoder. I didn't expect new capabilities to be added in the v2 → v3 switch
inteon
force-pushed
the
remove_unused_code
branch
from
9c0c75c to
b2efacf
Compare
| @@ -196,6 +211,15 @@ func convertToJSONableObject(yamlObj interface{}, jsonTarget *reflect.Value) (in | |||
| } | |||
| } | |||
|
|
|||
| // Transform map[string]interface{} into map[interface{}]interface{} | |||
There was a problem hiding this comment.
Is the need for this new? What is the cost of this?
There was a problem hiding this comment.
Yes, yamlv3 unmarshals maps into map[string]interface{} if all keys are strings, while yamlv2 did unmarshal all maps into map[interface{}]interface{}.
There was a problem hiding this comment.
JSON only deals with map[string]interface{}, and it will marshal the same… do we need to convert back to map[interface{}]interface{}?
| @@ -227,7 +251,7 @@ func convertToJSONableObject(yamlObj interface{}, jsonTarget *reflect.Value) (in | |||
| // Stolen from go-yaml to use the same conversion to string as | |||
| // the go-yaml library uses to convert float to string when | |||
| // Marshaling. | |||
| s := strconv.FormatFloat(typedKey, 'g', -1, 32) | |||
| s := strconv.FormatFloat(typedKey, 'g', -1, 64) | |||
There was a problem hiding this comment.
Will this result in visibly different output? Any changes have the potential to break consumers so we need to be extremely careful about changes that break byte-for-byte round-tripping
|
After digging through several layers of transitive dependencies, I've discovered that this PR will solve a YAML parsing issue in a downstream application that uses |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Switches from the 'yaml.v2' fork to the 'yaml.v3' fork and removes workarounds that are no longer necessary.