Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Go 1.10+ files #118

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

skitt
Copy link
Member

@skitt skitt commented Oct 8, 2024

go.mod requires Go 1.12, separate 1.10+ files are no longer needed. This merges their contents with the main files.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2024
@dims
Copy link
Member

dims commented Oct 8, 2024

once #119 merges, let's rebase this one @skitt

go.mod requires Go 1.12, separate 1.10+ files are no longer needed.
This merges their contents with the main files.

Signed-off-by: Stephen Kitt <[email protected]>
@skitt skitt force-pushed the drop-go1.10-build branch from 02c8e8f to ea138a0 Compare October 8, 2024 12:44
@skitt
Copy link
Member Author

skitt commented Oct 8, 2024

@dims done!

@dims
Copy link
Member

dims commented Oct 8, 2024

/approve
/lgtm

thanks @skitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 119290a into kubernetes-sigs:master Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants