fix: enforce int64 for large integer values in tests

[arthurbdiniz]

The bug arises from the use of generic integer types (int) in test cases involving large numerical values that exceed the range of a 32-bit integer.

In Go, the size of the int type depends on the platform, this behavior causes inconsistencies when handling large integers, such as -9223372036854775808 and 9007199254740993.

On 32-bit systems, these values cannot be represented correctly as int, leading to potential overflow or truncation errors. By explicitly using the int64 type in the affected test cases, the code ensures proper handling and representation of large integers across all platforms, avoiding platform-specific bugs and improving the reliability of the tests.

Reproduce

Run tests setting GOARCH to 386.

GOARCH=386 GOOS=linux go test -vet=off -v -p 2 sigs.k8s.io/yaml sigs.k8s.io/yaml/goyaml.v2 sigs.k8s.io/yaml/goyaml.v3


# sigs.k8s.io/yaml/goyaml.v2_test [sigs.k8s.io/yaml/goyaml.v2.test]
goyaml.v2/decode_test.go:134:33: cannot use -9223372036854775808 (untyped int constant) as int value in map literal (overflows)
# sigs.k8s.io/yaml [sigs.k8s.io/yaml.test]
./yaml_test.go:186:50: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in argument to fmt.Sprintf (overflows)
./yaml_test.go:415:16: cannot use 9007199254740993 (untyped int constant) as int value in struct literal (overflows)
FAIL	sigs.k8s.io/yaml [build failed]
FAIL	sigs.k8s.io/yaml/goyaml.v2 [build failed]
# sigs.k8s.io/yaml/goyaml.v3_test [sigs.k8s.io/yaml/goyaml.v3.test]
goyaml.v3/decode_test.go:180:33: cannot use -9223372036854775808 (untyped int constant) as int value in map literal (overflows)
FAIL	sigs.k8s.io/yaml/goyaml.v3 [build failed]
FAIL

Changes

• Updated test cases in goyaml.v2 and goyaml.v3 decode_test.go to explicitly use int64 for representing large integer values.
• Adjusted yaml_test.go to:
  • Use int64 for math.MaxInt64 in marshaling tests.
  • Decode integers greater than 2^53 into int64 instead of int to ensure proper handling of large values.

These changes address potential issues with integer overflow and ensure compatibility across platforms with differing integer size representations.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arthurbdiniz
Once this PR has been reviewed and has the lgtm label, please assign jpbetz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

• ✅login: arthurbdiniz / (a5e2979)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @arthurbdiniz!

It looks like this is your first PR to kubernetes-sigs/yaml 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/yaml has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[arthurbdiniz]

Added an amended commit to my fork and for some reason it was not synced here.

master...arthurbdiniz:yaml:fix/tests-32bit-architectures