Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more precise logging for VPA resource recommendations #6723

Merged
merged 7 commits into from
May 29, 2024
Merged

Add more precise logging for VPA resource recommendations #6723

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dde06f5
Add more precise logging for VPA resource recommendations
nikimanoledaki Apr 17, 2024
33a2220
Add func with targets of processed recommendations
nikimanoledaki May 15, 2024
1277ff6
Remove capped recommendation log
nikimanoledaki May 15, 2024
093618e
Handle nil values for VPA targets log
nikimanoledaki May 15, 2024
1800a6e
autoscaler: only log non-zero values for processed recommendations
nikimanoledaki May 27, 2024
390b061
Add doc comment for VPA Updater's GetProcessedRecommendationTargets func
nikimanoledaki May 27, 2024
9a57ecd
Change mem value to kilobyte
nikimanoledaki May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (calc *UpdatePriorityCalculator) AddPod(pod *apiv1.Pod, now time.Time) {
klog.V(4).Infof("not updating pod %v/%v because resource would not change", pod.Namespace, pod.Name)
return
}
klog.V(2).Infof("pod accepted for update %v/%v with priority %v", pod.Namespace, pod.Name, updatePriority.ResourceDiff)
klog.V(2).Infof("pod accepted for update %v/%v with priority %v", pod.Namespace, pod.Name, updatePriority.ResourceDiff, processedRecommendation)
nikimanoledaki marked this conversation as resolved.
Show resolved Hide resolved
calc.pods = append(calc.pods, prioritizedPod{
pod: pod,
priority: updatePriority,
Expand Down
1 change: 1 addition & 0 deletions vertical-pod-autoscaler/pkg/utils/vpa/capping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ func getCappedRecommendationForContainer(
cappingAnnotations = append(cappingAnnotations, annotations...)
}
}
klog.V(3).Infof("processed capped recommendations for %s: %v", container.Name, cappingAnnotations)
nikimanoledaki marked this conversation as resolved.
Show resolved Hide resolved
}

process(cappedRecommendations.Target, true)
Expand Down
Loading