feat: add args mode

kubeshop · Apr 19, 2023 · dc6e2d8 · dc6e2d8
1 parent ecf1391
commit dc6e2d8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/apis/executor/v1/executor_types.go b/apis/executor/v1/executor_types.go
@@ -40,9 +40,9 @@ type ExecutorSpec struct {
 
 	// Image for kube-job
 	Image string `json:"image,omitempty"`
-	// container executor binary arguments
+	// executor binary arguments
 	Args []string `json:"args,omitempty"`
-	// container executor default binary command
+	// executor default binary command
 	Command []string `json:"command,omitempty"`
 	// container executor default image pull secrets
 	ImagePullSecrets []v1.LocalObjectReference `json:"imagePullSecrets,omitempty"`

diff --git a/apis/tests/v3/test_types.go b/apis/tests/v3/test_types.go
@@ -165,7 +165,9 @@ type ExecutionRequest struct {
 	TestSuiteSecretUUID string `json:"testSuiteSecretUUID,omitempty"`
 	// additional executor binary arguments
 	Args []string `json:"args,omitempty"`
-	// container executor binary command
+	// usage mode for arguments
+	ArgsMode string `json:"argsMode,omitempty"`
+	// executor binary command
 	Command []string `json:"command,omitempty"`
 	// container executor image
 	Image string `json:"image,omitempty"`

diff --git a/config/crd/bases/executor.testkube.io_executors.yaml b/config/crd/bases/executor.testkube.io_executors.yaml
@@ -36,12 +36,12 @@ spec:
             description: ExecutorSpec defines the desired state of Executor
             properties:
               args:
-                description: container executor binary arguments
+                description: executor binary arguments
                 items:
                   type: string
                 type: array
               command:
-                description: container executor default binary command
+                description: executor default binary command
                 items:
                   type: string
                 type: array

diff --git a/config/crd/bases/tests.testkube.io_tests.yaml b/config/crd/bases/tests.testkube.io_tests.yaml
@@ -451,6 +451,9 @@ spec:
                     items:
                       type: string
                     type: array
+                  argsMode:
+                    description: usage mode for arguments
+                    type: string
                   artifactRequest:
                     description: artifact request body for container executors with
                       test artifacts
@@ -471,7 +474,7 @@ spec:
                     - volumeMountPath
                     type: object
                   command:
-                    description: container executor binary command
+                    description: executor binary command
                     items:
                       type: string
                     type: array