fix panic when timeout is nil in gitlab cloneOptions (#1016)

Co-authored-by: jackyu <[email protected]>
kubesphere · Oct 26, 2023 · 520ede6 · 520ede6
1 parent 6afb8d9
commit 520ede6
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/pkg/client/devops/jenkins/internal/gitlab.go b/pkg/client/devops/jenkins/internal/gitlab.go
@@ -145,11 +145,15 @@ func GetGitlabSourceFromEtree(source *etree.Element) (gitSource *devopsv1alpha3.
 				if value, err := strconv.ParseBool(cloneExtension.SelectElement("shallow").Text()); err == nil {
 					gitSource.CloneOption.Shallow = value
 				}
-				if value, err := strconv.ParseInt(cloneExtension.SelectElement("timeout").Text(), 10, 32); err == nil {
-					gitSource.CloneOption.Timeout = int(value)
+				if timeout := cloneExtension.SelectElement("timeout"); timeout != nil {
+					if value, err := strconv.ParseInt(timeout.Text(), 10, 32); err == nil {
+						gitSource.CloneOption.Timeout = int(value)
+					}
 				}
-				if value, err := strconv.ParseInt(cloneExtension.SelectElement("depth").Text(), 10, 32); err == nil {
-					gitSource.CloneOption.Depth = int(value)
+				if depth := cloneExtension.SelectElement("depth"); depth != nil {
+					if value, err := strconv.ParseInt(depth.Text(), 10, 32); err == nil {
+						gitSource.CloneOption.Depth = int(value)
+					}
 				}
 			}
 		}