Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dry run to preference requirement test #292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RoniKishner
Copy link
Contributor

What this PR does / why we need it:
Added dry run to preference requirement test to reduce run time

Special notes for your reviewer:
discussed #287

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 27, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lyarwood for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add it to other tests where appropriate as well?

@lyarwood
Copy link
Member

Can you please add it to other tests where appropriate as well?

@0xFelix thinking about this some more, while we do validate things fully in the admission webhooks at the moment there is a growing desire to move this logic into the controller to better support the eventual consistency.

@0xFelix
Copy link
Member

0xFelix commented Nov 28, 2024

@lyarwood In this case, we could do without using DryRun at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants