Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-infra, labels: add group to allow applying labels #3145

Merged

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Dec 22, 2023

Currently only maintainers (i.e. the folks inside kubevirtorg-label) can apply good-first-issue to project-infra issues.

Symptom: #3031 (comment)

Adds a group that can apply good-first-issue to project-infra issues.

Currently only maintainers (i.e. the folks inside kubevirtorg-label)
can apply good-first-issue.

Adds a group that can apply good-first-issue to project-infra issues.

Signed-off-by: Daniel Hiller <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 22, 2023
@dhiller
Copy link
Contributor Author

dhiller commented Dec 22, 2023

See #2940

@dhiller
Copy link
Contributor Author

dhiller commented Jan 10, 2024

/override pull-kubevirt-org-github-config-updater

The team doesn't exist yet so the job fails on checking the team.

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater

In response to this:

/override pull-kubevirt-org-github-config-updater

The team doesn't exist yet so the job fails on checking the team.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor Author

dhiller commented Jan 10, 2024

/override pull-project-infra-prow-deploy-test

Irrelevant to this change.

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-prow-deploy-test

In response to this:

/override pull-project-infra-prow-deploy-test

Irrelevant to this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor Author

dhiller commented Jan 10, 2024

@xpivarc @enp0s3 @brianmcarey FYI

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@brianmcarey
Copy link
Member

/override pull-kubevirt-org-github-config-updater

expected failure as this PR is creating the group that the job fails to find.

@kubevirt-bot
Copy link
Contributor

@brianmcarey: Overrode contexts on behalf of brianmcarey: pull-kubevirt-org-github-config-updater

In response to this:

/override pull-kubevirt-org-github-config-updater

expected failure as this PR is creating the group that the job fails to find.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 3f0cf6d into kubevirt:main Jan 11, 2024
5 checks passed
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the plugins configmap in namespace kubevirt-prow at cluster default using the following files:

  • key plugins.yaml using file github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml

In response to this:

Currently only maintainers (i.e. the folks inside kubevirtorg-label) can apply good-first-issue to project-infra issues.

Symptom: #3031 (comment)

Adds a group that can apply good-first-issue to project-infra issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants