Merge pull request #221 from fabriziosestito/chore/change-visibility-…

…report-constants chore(report): constants should be private
kubewarden · Mar 11, 2024 · 62f4a1a · 62f4a1a
2 parents 7e56394 + deb824d
commit 62f4a1a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/internal/report/constants.go b/internal/report/constants.go
@@ -3,7 +3,7 @@ package report
 const (
 	policyReportSource            = "kubewarden"
 	propertyPolicyResourceVersion = "policy-resource-version"
-	PropertyPolicyUID             = "policy-uid"
+	propertyPolicyUID             = "policy-uid"
 )
 
 const (
@@ -34,5 +34,5 @@ const (
 
 const (
 	labelAppManagedBy = "app.kubernetes.io/managed-by"
-	LabelApp          = "kubewarden"
+	labelApp          = "kubewarden"
 )
diff --git a/internal/report/report.go b/internal/report/report.go
@@ -18,7 +18,7 @@ func NewPolicyReport(resource unstructured.Unstructured) *wgpolicy.PolicyReport
 			Name:      string(resource.GetUID()),
 			Namespace: resource.GetNamespace(),
 			Labels: map[string]string{
-				labelAppManagedBy: LabelApp,
+				labelAppManagedBy: labelApp,
 			},
 			OwnerReferences: []metav1.OwnerReference{
 				{
@@ -75,7 +75,7 @@ func NewClusterPolicyReport(resource unstructured.Unstructured) *wgpolicy.Cluste
 		ObjectMeta: metav1.ObjectMeta{
 			Name: string(resource.GetUID()),
 			Labels: map[string]string{
-				labelAppManagedBy: LabelApp,
+				labelAppManagedBy: labelApp,
 			},
 			OwnerReferences: []metav1.OwnerReference{
 				{
@@ -194,7 +194,7 @@ func computeProperties(policy policiesv1.Policy) map[string]string {
 	// same result can be reused in the next scan
 	// https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency
 	properties[propertyPolicyResourceVersion] = policy.GetResourceVersion()
-	properties[PropertyPolicyUID] = string(policy.GetUID())
+	properties[propertyPolicyUID] = string(policy.GetUID())
 
 	return properties
 }
diff --git a/internal/report/report_test.go b/internal/report/report_test.go
@@ -151,7 +151,7 @@ func TestNewPolicyReportResult(t *testing.T) {
 				SubjectSelector: &metav1.LabelSelector{},
 				Description:     "",
 				Properties: map[string]string{
-					PropertyPolicyUID:             "policy-uid",
+					propertyPolicyUID:             "policy-uid",
 					propertyPolicyResourceVersion: "1",
 					typeValidating:                valueTypeTrue,
 				},
@@ -192,7 +192,7 @@ func TestNewPolicyReportResult(t *testing.T) {
 				SubjectSelector: &metav1.LabelSelector{},
 				Description:     "The request was rejected",
 				Properties: map[string]string{
-					PropertyPolicyUID:             "policy-uid",
+					propertyPolicyUID:             "policy-uid",
 					propertyPolicyResourceVersion: "1",
 					typeMutating:                  valueTypeTrue,
 				},
@@ -229,7 +229,7 @@ func TestNewPolicyReportResult(t *testing.T) {
 				SubjectSelector: &metav1.LabelSelector{},
 				Description:     "",
 				Properties: map[string]string{
-					PropertyPolicyUID:             "policy-uid",
+					propertyPolicyUID:             "policy-uid",
 					propertyPolicyResourceVersion: "1",
 					typeValidating:                valueTypeTrue,
 				},