Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DropdownMenuButton): RemoteDialogTrigger の考慮漏れを修正 #5147

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(DropdownMenuButton): RemoteDialogTrigger の考慮漏れを修正 #5147

merged 1 commit into from
Nov 28, 2024
+17 −7

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Nov 28, 2024

関連URL

概要

DropdownMenuButton の children に RemoteDialogTrigger を指定できることを考慮できていなかったので修正しました。

変更内容

  • DropdownMenuButton が Button / AnchorButton だけでなく RemoteDialogTrigger にも意図したスタイリングが当たるように修正
  • RemoteDialogTrigger に与えた props が内包要素に引き継がれるように修正
  • Story を拡充

確認方法

@uknmr uknmr requested a review from a team as a code owner November 28, 2024 05:21
@uknmr uknmr requested review from AtsushiM and nabeliwo and removed request for a team November 28, 2024 05:21
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 28, 2024

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5147

commit: dcf35f0

AtsushiM
AtsushiM approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@AtsushiM AtsushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uknmr uknmr merged commit 63f209a into master Nov 28, 2024
12 checks passed
@uknmr uknmr deleted the fix-DropdownMenuButton-RemoteDialogTrigger branch November 28, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtsushiM AtsushiM AtsushiM approved these changes

@nabeliwo nabeliwo Awaiting requested review from nabeliwo nabeliwo is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uknmr @AtsushiM