Using absolute paths instead of relative ones #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using absolute paths in demos
|
The short version is that the demos are just demos. They are not suposed to be very generic/dynamic just illustrate how the user can use the nmpc-framework to generate controllers. I think this was just a case of me somehow forgetting to adjust a path in the demo's when moving the repo's into the new submodule structure. Il think about this pull request, not sure if we should make it dynamic. |
|
i just ran the demos everything works fine, did you run demos/TwoCircles from the demos folder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a function called
get_nmpc_codegen_matlab_rootdirwhich returns the path to the root directory ofnmpc-codegen-matlab.It's unclear to me how to obtain the root directory of
nmpc-codegen.One idea is that if the user has got the code from github using
git clone --recursive, then thenmpc-codegenis a submodule which is found in{nmpc-codegen-matlab-rootdir}/kernel/.