Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mp boms #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/mp boms #172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf74f5
added BOMs for MP specs
jmezna Jun 10, 2020
d82f1d0
added MP BOM with latest MP version
jmezna Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions profiles/micro-profile-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<artifactId>kumuluzee-profiles</artifactId>
<groupId>com.kumuluz.ee</groupId>
<version>3.11.0-SNAPSHOT</version>
</parent>
<modelVersion>4.0.0</modelVersion>

<name>KumuluzEE MicroProfile BOM</name>
<description>
KumuluzEE MicroProfile which includes and tracks the latest community based specification found at
https://microprofile.io, which focuses on technologies best-suited to build modern Java based cloud
applications that follow the microservice architecture. The main KumuluzEE profile includes the reference
implementations of the profile/specification.
</description>

<artifactId>kumuluzee-microProfile-bom</artifactId>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.kumuluz.ee</groupId>
<artifactId>kumuluzee-microProfile-3.3-bom</artifactId>
<version>${project.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

</project>
2 changes: 1 addition & 1 deletion profiles/micro-profile/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
implementations of the profile/specification.
</description>

<artifactId>kumuluzee-micro-profile</artifactId>
<artifactId>kumuluzee-microProfile</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the naming of the MP artifacts was inconsistent. But this is however breaking change so discussion is welcome.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to preserve backward compatibility. Either leave kumuluzee-micro-profile or define both (kumuluzee-micro-profile and kumuluzee-microProfile).


<dependencies>
<dependency>
Expand Down
1 change: 1 addition & 0 deletions profiles/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
</description>
<modules>
<module>micro-profile</module>
<module>micro-profile-bom</module>
<module>micro-profile-1.0</module>
<module>micro-profile-1.1</module>
<module>micro-profile-1.1-bom</module>
Expand Down