Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: id generation algorithm for complex filters #71

Closed
wants to merge 2 commits into from

Conversation

inkedsquid
Copy link

@inkedsquid inkedsquid commented Apr 18, 2024

What does this PR do ?

The filter ID generation algorithm is potentially flawed, complex filters like

{
        "and" : [ 
          { "equals": { "city": "Montpellier" } }, 
          { "equals": { "city": "Nimes"} } 
        ]
}

and

{
        "and" : [ 
          { "equals": { "city": "Montpellier"} }, 
          { "equals": { "city": "Lyon"} } 
        ]
}

will inherently get the same ID although they are different.

This PR isn't done and only represent the current issue Koncorde filters ID have.

@inkedsquid inkedsquid self-assigned this Apr 18, 2024
@inkedsquid
Copy link
Author

This seems to be logical behavior, closing this PR

@inkedsquid inkedsquid closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant