Update to compatible docker compose usage #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolljee
requested review from
alexandrebouthinon,
Kuruyia and
OlivierCavadenti
ScreamZ
approved these changes
Nov 14, 2023
Kuruyia
suggested changes
Nov 14, 2023
src/commands/app/start-services.ts
Outdated
| const matches = docov.stdout.match(/[^0-9.]*([0-9.]*).*/); | ||
| if (matches === null) { | ||
| throw new Error( | ||
| "Unable to read docker-compose verson. This is weird." | ||
| "Unable to read docker compose verson. This is weird." | ||
| ); | ||
| } | ||
| const docoVersion = matches.length > 0 ? matches[1] : null; |
There was a problem hiding this comment.
This check seems wrong. It should check that there is at least two matches: matches.length >= 2
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Co-authored-by: Kuruyia <[email protected]>
Kuruyia
suggested changes
Nov 15, 2023
Co-authored-by: Kuruyia <[email protected]>
Merged
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR update kourou to use docker compose instead of docker-compose
How should this be manually tested?
...
Other changes
Boyscout