Update linting rules

kuzzleio · Nov 4, 2024 · f9fe638 · f9fe638
1 parent 4b23300
commit f9fe638
Show file tree

Hide file tree

Showing 13 changed files with 1,118 additions and 1,455 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -7,4 +7,33 @@ module.exports = {
     project: path.join(__dirname, 'tsconfig.json'),
   },
   ignorePatterns: ['dist/*'],
+  rules: {
+    '@typescript-eslint/strict-boolean-expressions': 'off',
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/restrict-template-expressions': 'off',
+    '@typescript-eslint/prefer-optional-chain': 'off',
+    '@typescript-eslint/no-floating-promises': 'off',
+    '@typescript-eslint/ban-ts-comment': 'off',
+    '@typescript-eslint/restrict-plus-operands': 'off',
+    '@typescript-eslint/prefer-nullish-coalescing': 'off',
+    '@typescript-eslint/no-empty-function': 'off',
+    '@typescript-eslint/naming-convention': 'off',
+    '@typescript-eslint/no-unused-vars': 'off',
+    '@typescript-eslint/require-array-sort-compare': 'off',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/ban-types': 'off',
+    '@typescript-eslint/no-dynamic-delete': 'off',
+    'vue/multi-word-component-names': 'off',
+    'vue/block-lang': 'off',
+    'vue/no-mutating-props': 'off',
+    'array-callback-return': 'off',
+    'vue/require-default-prop': 'off',
+    'vue/order-in-components': 'off',
+    'vue/no-useless-template-attributes': 'off',
+    'vue/no-reserved-component-names': 'off',
+    'vue/require-prop-types': 'off',
+    'vue/no-lone-template': 'off',
+    'default-case-last': 'warn',
+    'import/order': 'warn'
+  },
 };
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -71,7 +71,7 @@
     "eslint-plugin-cypress": "^3.5.0",
     "eslint-plugin-vue-kuzzle": "^0.0.13",
     "file-loader": "^6.2.0",
-    "kuzzle": "^2.31.0",
+    "kuzzle": "^2.33.0",
     "rollup-plugin-visualizer": "^5.12.0",
     "sass": "~1.63.6",
     "ts-mock-imports": "^1.3.16",

diff --git a/src/components/Common/Filters/FavoriteFilterItem.vue b/src/components/Common/Filters/FavoriteFilterItem.vue
@@ -86,10 +86,10 @@ export default {
       this.$emit('favoris-delete', this.favorite.id);
     },
     useFilter() {
-      if (this.favorite.active == 'raw') {
+      if (this.favorite.active === 'raw') {
         this.$parent.$emit('filter-raw-submitted', this.favorite.raw, true);
       }
-      if (this.favorite.active == 'basic') {
+      if (this.favorite.active === 'basic') {
         this.$parent.$emit(
           'filter-basic-submitted',
           this.favorite.basic,
@@ -100,8 +100,8 @@ export default {
     },
     getFilter() {
       const loadedFilter = Object.assign(new filterManager.Filter(), this.favorite);
-      if (loadedFilter.active == 'basic') return loadedFilter.basic;
-      if (loadedFilter.active == 'raw') return loadedFilter.raw;
+      if (loadedFilter.active === 'basic') return loadedFilter.basic;
+      if (loadedFilter.active === 'raw') return loadedFilter.raw;
     },
     toggleCollapse() {
       this.expanded = !this.expanded;

diff --git a/src/components/Common/Filters/FilterHistoryItem.vue b/src/components/Common/Filters/FilterHistoryItem.vue
@@ -123,8 +123,8 @@ export default {
     },
     getFilter() {
       const loadedFilter = Object.assign(new filterManager.Filter(), this.filter);
-      if (loadedFilter.active == 'basic') return loadedFilter.basic;
-      if (loadedFilter.active == 'raw') return loadedFilter.raw;
+      if (loadedFilter.active === 'basic') return loadedFilter.basic;
+      if (loadedFilter.active === 'raw') return loadedFilter.raw;
     },
     toggleCollapse() {
       this.expanded = !this.expanded;

diff --git a/src/components/Common/JsonEditor.vue b/src/components/Common/JsonEditor.vue
@@ -3,10 +3,10 @@
 </template>
 
 <script>
+import Vue from 'vue';
 import ace from 'ace-builds';
 import 'ace-builds/src-noconflict/theme-tomorrow';
 import 'ace-builds/src-noconflict/mode-json';
-import Vue from 'vue';
 
 export default {
   name: 'JsonEditor',

diff --git a/src/components/Common/Stepper.vue b/src/components/Common/Stepper.vue
@@ -6,7 +6,7 @@
           <div
             class="Stepper-step col s1"
             :class="{
-              disabled: disabledSteps.indexOf(index) != -1,
+              disabled: disabledSteps.indexOf(index) !== -1,
               'offset-s4': index === 0,
             }"
           >

diff --git a/src/components/Data/Leftnav/IndexBranch.vue b/src/components/Data/Leftnav/IndexBranch.vue
@@ -143,7 +143,7 @@ export default {
         this.open = true;
       }
 
-      if (this.filter == '') {
+      if (this.filter === '') {
         this.open = false;
       }
     },

diff --git a/src/components/Materialize/Pagination.vue b/src/components/Materialize/Pagination.vue
@@ -1,12 +1,12 @@
 <template>
   <div>
     <ul class="pagination">
-      <li :class="{ disabled: currentPage == 1 }" class="chevron" @click.prevent="firstPage">
+      <li :class="{ disabled: currentPage === 1 }" class="chevron" @click.prevent="firstPage">
         <a href="#">
           <i class="fa fa-angle-double-left fast-pagination waves-effect" />
         </a>
       </li>
-      <li :class="{ disabled: currentPage == 1 }" class="chevron" @click.prevent="previousPage">
+      <li :class="{ disabled: currentPage === 1 }" class="chevron" @click.prevent="previousPage">
         <a href="#" class="waves-effect">
           <i class="fa fa-chevron-left" />
         </a>
@@ -22,12 +22,12 @@
         <a href="#">{{ n }}</a>
       </li>
 
-      <li :class="{ disabled: currentPage == pages }" class="chevron" @click.prevent="nextPage">
+      <li :class="{ disabled: currentPage === pages }" class="chevron" @click.prevent="nextPage">
         <a href="#">
           <i class="fa fa-chevron-right waves-effect" />
         </a>
       </li>
-      <li :class="{ disabled: currentPage == pages }" class="chevron" @click.prevent="lastPage">
+      <li :class="{ disabled: currentPage === pages }" class="chevron" @click.prevent="lastPage">
         <a href="#">
           <i class="fa fa-angle-double-right fast-pagination waves-effect" />
         </a>

diff --git a/src/components/Materialize/Toaster.vue b/src/components/Materialize/Toaster.vue
@@ -8,7 +8,7 @@ import { useToasterStore } from '@/stores';
 const toasterStore = useToasterStore();
 
 toasterStore.$subscribe((_mutation, state) => {
-  if (state.toast != undefined) {
+  if (state.toast !== undefined) {
     // TODO: Import Materialize properly
     // @ts-expect-error
     M.toast({

diff --git a/src/main.ts b/src/main.ts
@@ -1,19 +1,19 @@
 import Vue from 'vue';
 import { BootstrapVue, BootstrapVueIcons } from 'bootstrap-vue';
 import { createPinia, PiniaVuePlugin } from 'pinia';
+import VueFormGenerator from 'vue-form-generator';
 import VueRouter from 'vue-router';
 
-import createRoutes from './routes/index';
 import './plugins/logger';
-import { useKuzzleStore } from './stores';
-import VueFormGenerator from 'vue-form-generator';
+import 'leaflet/dist/leaflet.css';
 import 'vue-form-generator/dist/vfg.css';
 
-import DateTimeFormInput from '@/components/Data/Documents/FormInputs/DateTimeFormInput.vue';
-import JsonFormInput from '@/components/Data/Documents/FormInputs/JsonFormInput.vue';
-import 'leaflet/dist/leaflet.css';
+import { useKuzzleStore } from './stores';
 
 import App from './App.vue';
+import createRoutes from './routes/index';
+import DateTimeFormInput from '@/components/Data/Documents/FormInputs/DateTimeFormInput.vue';
+import JsonFormInput from '@/components/Data/Documents/FormInputs/JsonFormInput.vue';
 
 Reflect.defineProperty(window, 'kuzzle', {
   get() {

diff --git a/src/services/kuzzleWrapper-v1.ts b/src/services/kuzzleWrapper-v1.ts
@@ -12,17 +12,6 @@ import type { MappingAttributes } from './mappingHelpers';
 // corresponding to the selected environment.
 export const kuzzle = new Kuzzle(new WebSocket('localhost'));
 
-// Helper for performSearch
-const getValueAdditionalAttribute = (content, attributePath) => {
-  const attribute = attributePath.shift();
-
-  if (typeof content[attribute] === 'object') {
-    return getValueAdditionalAttribute(content[attribute], attributePath);
-  }
-
-  return content[attribute];
-};
-
 function buildCaseInsensitiveRegexp(searchString) {
   return searchString
     .split('')
@@ -76,9 +65,9 @@ export class KuzzleWrapperV1 {
 
     try {
       await this.kuzzle.connect();
-    } catch (error) {
+    } catch (error: any) {
       if (error.message.match(/^Incompatible SDK client/)) {
-        const e = new Error(error);
+        const e = new Error(error) as any;
         e.id = 'api.process.incompatible_sdk_version';
         throw e;
       }
@@ -116,15 +105,6 @@ export class KuzzleWrapperV1 {
     const strategies = await this.kuzzle.auth.getStrategies();
 
     const result = await this.kuzzle.security.searchUsers({ ...filters, sort }, { ...pagination });
-    let additionalAttributeName: any = null;
-
-    if (sort.length > 0) {
-      if (typeof sort[0] === 'string') {
-        additionalAttributeName = sort[0];
-      } else {
-        additionalAttributeName = Object.keys(sort[0])[0];
-      }
-    }
 
     const users: any[] = [];
     for (const user of result.hits) {

diff --git a/src/stores/kuzzle.ts b/src/stores/kuzzle.ts
@@ -97,7 +97,7 @@ export const useKuzzleStore = defineStore('kuzzle', {
 
       return payload.id;
     },
-    deleteEnvironment(id) {
+    deleteEnvironment(id: string) {
       if (!Object.keys(this.environments).includes(id)) {
         return;
       }
@@ -111,7 +111,7 @@ export const useKuzzleStore = defineStore('kuzzle', {
 
       localStorage.setItem(LS_ENVIRONMENTS, JSON.stringify(this.environments));
     },
-    updateTokenCurrentEnvironment(payload) {
+    updateTokenCurrentEnvironment(payload: any) {
       if (!this.currentId || this.currentEnvironment == null) {
         throw new Error('No current environment selected');
       }
@@ -126,7 +126,7 @@ export const useKuzzleStore = defineStore('kuzzle', {
 
       localStorage.setItem(LS_ENVIRONMENTS, JSON.stringify(this.environments));
     },
-    updateEnvironment(payload) {
+    updateEnvironment(payload: any) {
       let mustReconnect = false;
 
       if (
@@ -193,7 +193,7 @@ export const useKuzzleStore = defineStore('kuzzle', {
         throw new Error(`Id ${id} does not match any environment`);
       }
 
-      await this.setCurrentEnvironment(id);
+      this.setCurrentEnvironment(id);
       localStorage.setItem(LS_LAST_ENV, id);
 
       return await this.connectToCurrentEnvironment();
@@ -204,7 +204,7 @@ export const useKuzzleStore = defineStore('kuzzle', {
       this.errorFromKuzzle = error.message;
     },
     loadEnvironments() {
-      const loadedEnv = JSON.parse(localStorage.getItem(LS_ENVIRONMENTS) || '{}');
+      const loadedEnv = JSON.parse(localStorage.getItem(LS_ENVIRONMENTS) ?? '{}');
 
       Object.keys(loadedEnv).forEach((envId) => {
         const env = loadedEnv[envId];
@@ -228,7 +228,7 @@ export const useKuzzleStore = defineStore('kuzzle', {
         this.currentId = currentId;
       } else {
         currentId = localStorage.getItem(LS_LAST_ENV);
-        this.setCurrentEnvironment(currentId || undefined);
+        this.setCurrentEnvironment(currentId ?? undefined);
       }
     },
   },