Update dependencies and GitHub actions #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuruyia
reviewed
Feb 1, 2024
| with: | ||
| node-version: "14" | ||
| node-version: "18.17.1" |
There was a problem hiding this comment.
Is it not enough to just use the latest minor of Node.js 18?
Suggested change
| node-version: "18.17.1" | |
| node-version: "18" |
There was a problem hiding this comment.
I tried, it seems that mocha, typescript and ESM module are bugged with the last version of Node 18, but it is working in the targeted 18.17.1 idk why ...
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "kuzzle-plugin-prometheus", | |||
| "version": "4.2.0", | |||
| "version": "4.1.1", | |||
There was a problem hiding this comment.
Why did this rollback from 4.2.0 to 4.1.1?
alexandrebouthinon
requested changes
Feb 1, 2024
tsconfig.json
Outdated
| "resolveJsonModule": true, | ||
| "esModuleInterop": true, | ||
| "experimentalDecorators": true, | ||
| "allowJs": false, | ||
| "skipLibCheck": true | ||
| "skipLibCheck": true, |
There was a problem hiding this comment.
This is a json file, the trailing coma will not work
Kuruyia
approved these changes
Feb 1, 2024
alexandrebouthinon
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Update deps, remove peer deps
How should this be manually tested?
Other changes
Boyscout