Merge pull request #2527 from kuzzleio/fix/global-types

Fix global type definitions
kuzzleio · Mar 21, 2024 · cc30ee7 · cc30ee7
2 parents 8f029a3 + 3daa10e
commit cc30ee7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/lib/kuzzle/kuzzle.ts b/lib/kuzzle/kuzzle.ts
@@ -926,4 +926,5 @@ class Kuzzle extends KuzzleEventEmitter {
   }
 }
 
+export { Kuzzle };
 module.exports = Kuzzle;
diff --git a/lib/types/Global.ts b/lib/types/Global.ts
@@ -1,19 +1,22 @@
 import { Backend } from "../core/backend";
+import { Kuzzle } from "../kuzzle";
 
-/* eslint-disable @typescript-eslint/no-namespace */
+/**
+ * This file contains global type declarations for Kuzzle.
+ * We need to use `var` so Typescript extends the globalThis type.
+ * See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#type-checking-for-globalthis
+ */
+
+/* eslint-disable no-var, vars-on-top */
 
 declare global {
-  namespace NodeJS {
-    interface Global {
-      kuzzle: any;
-      app: Backend;
-      NODE_ENV: string;
-    }
-  }
+  var app: Backend;
+  var kuzzle: Kuzzle;
+  var NODE_ENV: string;
 }
 
 global.NODE_ENV = process.env.NODE_ENV;
 
 export {};
 
-/* eslint-enable @typescript-eslint/no-namespace */
+/* eslint-enable no-var, vars-on-top*/
-Original file line number
+Diff line change
@@ Expand Up / @@ -926,4 +926,5 @@ class Kuzzle extends KuzzleEventEmitter { @@
       }
     }
+    export { Kuzzle };
     module.exports = Kuzzle;