-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript to elasticsearch service #2473
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
2c13783
Add typescript to elasticsearch service
rolljee 2396aad
Update default parameters
rolljee 1d07b8d
Update docker compose
rolljee f333d5a
Update imports, lint & types
rolljee 4acba1f
fix(lint): fixed lint and ts issues in elasticsearch file
rolljee 69f96cb
Typescript update
rolljee 6c95c7e
Fixes tests on elasticsearch
rolljee 1de1bef
insert space (linting)
rolljee b4c3cb1
Update import
rolljee d138c33
Testing
rolljee 733d3f9
Update to avoid breaking change
rolljee f6f3e62
Merge branch '2-dev' into feat/elasticsearch-typescript
rolljee 4414cfb
Update some commands
rolljee 319cd62
Merge ok
rolljee 613e69b
Merge branch '2-dev' into feat/elasticsearch-typescript
rolljee fadf567
Merge 2-dev
rolljee 7953f58
Functional tests legacy
rolljee c646f67
Update scrollId in features-legacy
rolljee 20eaa6d
Taking time to make sonarcloud happy
rolljee 0d41305
Mistake where made
rolljee 677c686
Sonarlint
rolljee 6128d70
Update types for linting and sonar
rolljee ad722c3
Uncomment lines
rolljee 1c1aa70
Merge branch '2-dev' of github.com:kuzzleio/kuzzle into feat/elastics…
rolljee bf2e080
Update classname to avoid modifying thing that don't need to
rolljee f8b1463
Revert some changes
rolljee 3f0ab19
Revert some changes
rolljee 739994b
Revert
rolljee c6cc290
Revert linting of some files
rolljee 4cafa70
Revert linting
rolljee 0e6b1cc
Revert
rolljee 4157839
Revert Linting
rolljee 9869be5
Merge branch '2-dev' into feat/elasticsearch-typescript
rolljee a98ac81
Merge branch '2-dev' into feat/elasticsearch-typescript
rolljee 6b5addb
Lint the application
rolljee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,4 +176,3 @@ class MqttApi extends ApiBase { | |
| } | ||
|
|
||
| module.exports = MqttApi; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Maybe your editor have bad configuration because final new line is generally required on projects